Re: [PATCH 7/8] dmaengine: ste_dma40: Use the BIT macro to replaceugly '(1 << x)'s

From: Harvey Harrison
Date: Tue Apr 09 2013 - 15:04:50 EST


On Tue, Apr 9, 2013 at 11:39 AM, Lee Jones <lee.jones@xxxxxxxxxx> wrote:
>
> The aim is to make the code that little more readable.
>
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> ---

>
> #define MAX(a, b) (((a) < (b)) ? (b) : (a))

Not part of your patch, but probably a good idea to switch to the
generic MAX macro, this
one is evaluating its args twice.

Cheers,

Harvey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/