Re: [PATCH] thermal: fix frequency table lookup bugs

From: Eduardo Valentin
Date: Tue Apr 09 2013 - 14:33:28 EST


On 09-04-2013 14:27, Andrew Bresticker wrote:
You do two things in this change on cpu_cooling.c: (1) fix the case where
the loop is kept running indefinitely. (2) Reserve a specific role for each
index in this function.

So the issue is that the changes are not independent. With just the
fix for the infinite loop, get_cpu_frequency() is still completely
broken because it is not interpreting the level correctly and will
return the wrong frequency (and thus not throttling correctly, which
is bad). Perhaps the commit should be more general, like "fix
handling of invalid frequency table entries"? What do you think?

It fits better. I am OK if we improve the commit title and description, providing better explanation of what is the issue (you have done already) and how what needed to be done to fix it.


Thanks,
Andrew



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/