RE: [PATCH] x86, mce: Print warning if MCE handler fails toregister /dev/mcelog

From: Luck, Tony
Date: Tue Apr 09 2013 - 14:31:49 EST


- misc_register(&mce_chrdev_device);
+ if (misc_register(&mce_chrdev_device) != 0)
+ pr_warn("Failed to register mcelog device\n");

Did this actually happen to you? Or is this just "good practice" to check the
return value from misc_register?

If this can really happen, we should remember that it failed and
just drop out of mce_log() early (no point in queueing up records
when there is no way for a user to ever access them).

-Tony
èº{.nÇ+‰·Ÿ®‰­†+%ŠËlzwm…ébëæìr¸›zX§»®w¥Š{ayºÊÚë,j­¢f£¢·hš‹àz¹®w¥¢¸ ¢·¦j:+v‰¨ŠwèjØm¶Ÿÿ¾«‘êçzZ+ƒùšŽŠÝj"ú!¶iO•æ¬z·švØ^¶m§ÿðà nÆàþY&—