Re: [5/7] i2c-designware: enable/disable the controller properly

From: Wolfram Sang
Date: Tue Apr 09 2013 - 05:09:25 EST



> +static void __i2c_dw_enable(struct dw_i2c_dev *dev, bool enable)
> +{
> + int timeout = 100;
> +
> + do {
> + dw_writel(dev, enable, DW_IC_ENABLE);
> + if ((dw_readl(dev, DW_IC_ENABLE_STATUS) & 1) == enable)
> + return;
> +
> + usleep_range(25, 250);

This would wait 25ms max. Is there a timeout value specified in the docs?

> + } while (timeout-- > 0);

while (timeout--)?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/