Re: [PATCH v2] bitmap: speedup in bitmap_find_free_region whenorder is 0

From: Andrew Morton
Date: Tue Apr 09 2013 - 00:19:05 EST


On Mon, 08 Apr 2013 20:18:20 -0700 Joe Perches <joe@xxxxxxxxxxx> wrote:

> On Mon, 2013-04-08 at 20:10 -0700, Andrew Morton wrote:
> > > --- a/lib/bitmap.c
> []
> > > + for (i = 0 ; i < nlongs_reg ; i++) {
> >
> > No space before the semicolon, please. checkpatch should warn about
> > this but it seems to be broken.
>
> There's no specific CodingStyle violation here

Let's fix CodingStyle then? Nobody puts spaces before semis - perish
the thought! (I count 4,254,057 versus 8,416 in .c)

> Adding --strict does bleat though.

And let's make it default please.

> # check for whitespace before a non-naked semicolon
> if ($line =~ /^\+.*\S\s+;/) {
> CHK("SPACING",
> "space prohibited before semicolon\n" . $herecurr);
> }
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/