Re: [char-misc-next 0/3 V6] Support NFC Device on MEI CL Bus

From: Greg KH
Date: Mon Apr 08 2013 - 20:08:26 EST


On Tue, Apr 09, 2013 at 02:41:32AM +0300, Tomas Winkler wrote:
> v5 -> v6
> 1. include/linux/uapi/mei/nfc.h - provides API also for pure
> user space implementation as found under Android.
> 2. Removed INTEL_MEI_BUS_NFC Kconfig option.
> The NFC info client is disconnected as soon as we
> get the FW info and the regular client is connected only when
> mei_cl_enable_device() is explicitly called from an nfc driver.
> The mei cl bus now doesn't connect NFC exclusively.
> 3. Added pn544 to the possibly detected NFC chipsets.
>
> Depends on:
> mei: bus: Add device enabling and disabling API

If this is a nfc device, why isn't it using the nfc_register_device()
and nfc_unregister_device() calls? Shouldn't you be using the in-kernel
nfc api we already have?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/