Re: [PATCH net,1/2] hyperv: Fix a kernel warning fromnetvsc_linkstatus_callback()

From: David Miller
Date: Mon Apr 08 2013 - 12:16:20 EST


From: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
Date: Fri, 5 Apr 2013 14:44:39 -0700

> The warning about local_bh_enable inside IRQ happens when disconnecting a
> virtual NIC.
>
> The reason for the warning is -- netif_tx_disable() is called when the NIC
> is disconnected. And it's called within irq context. netif_tx_disable() calls
> local_bh_enable() which displays warning if in irq.
>
> The fix is to remove the unnecessary netif_tx_disable & wake_queue() in the
> netvsc_linkstatus_callback().
>
> Reported-by: Richard Genoud <richard.genoud@xxxxxxxxx>
> Tested-by: Long Li <longli@xxxxxxxxxxxxx>
> Tested-by: Richard Genoud <richard.genoud@xxxxxxxxx>
> Signed-off-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> Reviewed-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/