Re: [PATCH] scripts/mod: add device table offsets file to list offiles to clean

From: Michal Marek
Date: Mon Apr 08 2013 - 10:34:16 EST


On 19.3.2013 08:00, Fernando Luis Vazquez Cao wrote:
> Hi Michal,
>
> On 2013/03/04 18:57, Fernando Luis VÃzquez Cao wrote:
>> From: Fernando Luis VÃzquez Cao <fernando@xxxxxxxxxxxxx>
>>
>> This file is generated so it does not get cleaned automagically. In
>> other words
>> we need to added to the clean-files list.
>>
>> Signed-off-by: Fernando Luis VÃzquez Cao <fernando@xxxxxxxxxxxxx>
>> ---
>>
>> diff -urNp linux-3.9-rc1-orig/scripts/mod/Makefile
>> linux-3.9-rc1/scripts/mod/Makefile
>> --- linux-3.9-rc1-orig/scripts/mod/Makefile 2013-03-04
>> 16:09:29.297904000 +0900
>> +++ linux-3.9-rc1/scripts/mod/Makefile 2013-03-04
>> 18:06:16.359389000 +0900
>> @@ -49,3 +49,5 @@ $(obj)/elfconfig.h: $(obj)/empty.o $(obj
>> $(call if_changed,elfconfig)
>> targets += elfconfig.h
>> +
>> +clean-files := $(devicetable-offsets-file)
>
> Do you see any problem with this patch?

Yes, it does not work, at least not on top of 3.9-rc1. You need to add
'scripts' to the $(clean-dirs) list in the main Makefile, so that make
clean descends into scripts/mod.

Michal

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/