Re: [PATCH 1/3] kernel/srcu: merge common code into a macro

From: Sebastian Andrzej Siewior
Date: Mon Apr 08 2013 - 06:06:11 EST


On 04/05/2013 09:21 AM, Lai Jiangshan wrote:
> Hi, Sebastian

Hi Lai,

> The patch hurts readability.
> The original code are simple enough, merging them as one macro
> gives us no benefit.

Except when you need to adjust the macro and you have to touch both of
them instead just one. But I don't have strong feelings for that one.

> Thanks
> Lai.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/