Re: [PATCH] mac80211_hwsim: Register and bind to driver

From: Johannes Berg
Date: Mon Apr 08 2013 - 05:13:08 EST


Looks fine, but ...

> @@ -2179,6 +2183,8 @@ static int __init init_mac80211_hwsim(void)
> if (IS_ERR(hwsim_class))
> return PTR_ERR(hwsim_class);
>
> + driver_register(&mac80211_hwsim_driver);
> +
> memset(addr, 0, ETH_ALEN);
> addr[0] = 0x02;

I think you forgot to update the error path to unregister the driver.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/