RE: [PATCH] ACPI: remove "config ACPI_DEBUG_FUNC_TRACE"

From: Zheng, Lv
Date: Sun Apr 07 2013 - 03:00:56 EST


> > > Kconfig symbol ACPI_DEBUG_FUNC_TRACE was only used (through its
> > > corresponding macro) in drivers/acpi/acpica/acmacros.h. That macro
> > > was removed from that header in v3.8, with commit
> > > 86ff0e508f88eda6e479a897476026055831d2d8 ("ACPICA: Fix unmerged
> > > acmacros.h divergences."). That commit did not explain why that
> > > macro was removed. But it seems that ACPI_DEBUG_FUNC_TRACE can
> now
> > > be removed too, as it is unused.
> >
> > Lv, can you please comment here?
>
> Sorry for the delayed reply.
>
> The commit should have done something that already have been done in the
> ACPICA.
> I'll take a look at this.

The original commit deleted CONFIG_ACPI_DEBUG_FUNC_TRACE from acmacros.h as it is in the __wrong__ place.
CONFIG_xxx is linux specific codes thus should appear in OSL layer - aclinux.h.
ACPICA specific codes should only use selective definitions in #ifdef ACPI_xxx style and such codes should be merged into ACPICA rather than being merged into Linux ACPI.

Now we have two choices:
Re-implement it in the aclinux.h using "ACPI_DEBUG_OUTPUT" defined/undefined or delete this kernel configuration item temporarily.

Thanks and best regards
-Lv
¢éì®&Þ~º&¶¬–+-±éÝ¥Šw®žË±Êâmébžìdz¹Þ)í…æèw*jg¬±¨¶‰šŽŠÝj/êäz¹ÞŠà2ŠÞ¨è­Ú&¢)ß«a¶Úþø®G«éh®æj:+v‰¨Šwè†Ù>Wš±êÞiÛaxPjØm¶Ÿÿà -»+ƒùdš_