Re: [PATCH] Add non-zero module sections to sysfs

[Rusty Russell]

Sebastian Wankerl <sisewank@xxxxxxxxxxxxx> writes:
> On 04/05/13 06:00, Rusty Russell wrote:
>> Sebastian Wankerl <sisewank@xxxxxxxxxxxxx> writes:
>>> On 04/04/13 03:00, Rusty Russell wrote:
>>>> Sebastian Wankerl <sisewank@xxxxxxxxxxxxx> writes:
>>>>> Add non-zero module sections to sysfs on architectures unequal to PARISC.
>>>>> KGDB needs all module sections for proper module debugging. Therefore, commit 
>>>>> 35dead4235e2b67da7275b4122fed37099c2f462 is revoked except for PARISC
>>>>> architecture.
>>>> #ifdef CONFIG_PARISC in the middle of kernel/module.c is super-ugly, and
>>>> wrong.
>>> I don't see why this is wrong. It used to load all sections to sysfs
>>> until the patch mentioned. Actually, it is the PARISC build chain which
>>> is broken.
>
> We worked on that topic further. Now we have another suggestion: would
> it be okay to add a field to struct module for use by kgdb where we save
> the section names for our use. This seems to be the most valuable
> solution as solving the sysfs stuff is rather hard.

It is hard.  But being a kernel hacker isn't just about making newbies
eat flaming death; sometimes we need to solve problems.

We'll see what we can do; but we'll continue this in the branch of the
thread that cc's linux-parisc...

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/