Re: [PATCH v2] Introduce Intel RAPL cooling device driver

From: Jacob Pan
Date: Fri Apr 05 2013 - 17:57:26 EST


On Fri, 05 Apr 2013 14:26:35 -0700
Joe Perches <joe@xxxxxxxxxxx> wrote:

> > +/* in the order of enum rapl_primitives */
> > +static struct rapl_primitive_info rpi[] = {
>
> const?
I do need to override one entry for a special case. The hardware uses a
different bit location for the same lock functionality.

The other comments are well taken,

--
Thanks,

Jacob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/