New Defect(s) reported by Coverity Scan

From: Scan Subscription
Date: Fri Apr 05 2013 - 11:32:34 EST



Hi,

Please find the latest report on new defect(s) that have been introduced to the Linux Kernel found with Coverity SCAN.


Defect(s) Reported-by: Coverity Scan:
___________________________________________________________________________
** CID 996157: Logically dead code (DEADCODE)
/net/mac80211/sta_info.c: 808
http://scan5.coverity.com:8080/sourcebrowser.htm?projectId=10063#mergedDefectId=996157

###########################################################################
Defect Details:
___________________________________________________________________________
CID 996157: Logically dead code (DEADCODE)
http://scan5.coverity.com:8080/sourcebrowser.htm?projectId=10063#mergedDefectId=996157

/net/mac80211/sta_info.c: 803 ( assignment)

797 for (i = 0; i < NUM_DEFAULT_KEYS; i++) {
798 __ieee80211_key_free(key_mtx_dereference(local, sta->gtk[i]));
>>> Assigning: "have_key" = "true".
799 have_key = true;
800 }
801 if (sta->ptk) {
802 __ieee80211_key_free(key_mtx_dereference(local, sta->ptk));
>>> Assigning: "have_key" = "true".
803 have_key = true;
804 }
805 mutex_unlock(&local->key_mtx);
806

>>> At condition "have_key", the value of "have_key" must be equal to 1.
>>> The condition "!have_key" cannot be true.

807 if (!have_key)
>>> CID 996157: Logically dead code (DEADCODE) Execution cannot reach
>>> this statement "synchronize_net();".
808 synchronize_net();
809
810 sta->dead = true;
811




________________________________________________________________________


To view the defects in Coverity Scan visit, http://scan5.coverity.com:8080.
If you don't have a username, you can register at http://scan.coverity.com/

Thank you,
Dakshesh Vyas
Coverity SCAN-ADMIN
scan-admin at coverity.com
http://scan.coverity.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/