Re: [PATCH 3/5] SOUND: hda_generic, fix uninitialized variable

From: Takashi Iwai
Date: Fri Apr 05 2013 - 01:20:27 EST


At Thu, 4 Apr 2013 22:32:10 +0200,
Jiri Slaby wrote:
>
> changed is not initialized in path_power_down_sync, but it is expected
> to be false in case no change happened in the loop. So set it to
> false.
>
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> Cc: Jaroslav Kysela <perex@xxxxxxxx>
> Cc: Takashi Iwai <tiwai@xxxxxxx>

Thanks, applied.


Takashi

> ---
> sound/pci/hda/hda_generic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/pci/hda/hda_generic.c b/sound/pci/hda/hda_generic.c
> index f0a422f..8299e40 100644
> --- a/sound/pci/hda/hda_generic.c
> +++ b/sound/pci/hda/hda_generic.c
> @@ -751,7 +751,7 @@ EXPORT_SYMBOL_HDA(snd_hda_activate_path);
> static void path_power_down_sync(struct hda_codec *codec, struct nid_path *path)
> {
> struct hda_gen_spec *spec = codec->spec;
> - bool changed;
> + bool changed = false;
> int i;
>
> if (!spec->power_down_unused || path->active)
> --
> 1.8.2
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/