Re: [PATCH 1/2] Revert "af_unix: dont send SCM_CREDENTIAL whendest socket is NULL"

From: David Miller
Date: Fri Apr 05 2013 - 00:47:38 EST


From: ebiederm@xxxxxxxxxxxx (Eric W. Biederman)
Date: Wed, 03 Apr 2013 19:13:35 -0700

>
> This reverts commit 14134f6584212d585b310ce95428014b653dfaf6.
>
> The problem that the above patch was meant to address is that af_unix
> messages are not being coallesced because we are sending unnecesarry
> credentials. Not sending credentials in maybe_add_creds totally
> breaks unconnected unix domain sockets that wish to send credentails
> to other sockets.
>
> In practice this break some versions of udev because they receive a
> message and the sending uid is bogus so they drop the message.
>
> Cc: stable@xxxxxxxxxxxxxxx
> Reported-by: Sven Joachim <svenjoac@xxxxxx>
> Signed-off-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/