Re: [PATCH v2 net-next 1/8] r8169: Remove firmware code

From: Francois Romieu
Date: Thu Apr 04 2013 - 19:42:44 EST


David Miller <davem@xxxxxxxxxxxxx> :
[...]
> I see there is still some discussion about dependencies between
> patch #5 and #6, is that resolved?

Yes.

> If so, should I just apply this series as-is ?

Yes.

- the series is imho -stable unfriendly: whoever wants to figure what
should be fed into a -stable branch will have a hard time. :o/
- the driver could had been more careful about firmware version/magic
checks and firmware opcodes recycling. It's a bit late. It won't
necessarily hurt.
- there is a whole release cycle ahead to find problems - if any - due
to the hw_start flow change. It seems sane.
- the relative amount of binary like cruft is going down.

I am not overflowed with enthusiasm but the gain should exceed the pain.

--
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/