Re: [PATCH 1/5 v3] USB: regroup all depends on USB within an if USBblock

[Felipe Balbi]

Hi,

On Thu, Apr 04, 2013 at 01:42:18PM -0400, Alan Stern wrote:
> > > diff --git a/drivers/usb/misc/sisusbvga/Kconfig b/drivers/usb/misc/sisusbvga/Kconfig
> > > index 30ea7ca..0d03a52 100644
> > > --- a/drivers/usb/misc/sisusbvga/Kconfig
> > > +++ b/drivers/usb/misc/sisusbvga/Kconfig
> > > @@ -1,7 +1,7 @@
> > >  
> > >  config USB_SISUSBVGA
> > >  	tristate "USB 2.0 SVGA dongle support (Net2280/SiS315)"
> > > -	depends on USB && (USB_MUSB_HDRC || USB_EHCI_HCD)
> > > +	depends on (USB_MUSB_HDRC || USB_EHCI_HCD)
> > 
> > is it just me or would everybody agree that depending on MUSB or EHCI
> > here is wrong ?
> 
> That line certainly looks like it could be removed entirely.  Perhaps 
> the original author can enlighten us.
> 
> In any case, it's not relevant to the purpose of this patch set.

right :-)

-- 
balbi

Attachment: signature.asc
Description: Digital signature