RE: [PATCH] x86, amd, mce: Prevent potential cpu-online oops

From: Luck, Tony
Date: Thu Apr 04 2013 - 12:05:34 EST


+ if (WARN_ON_ONCE(!nb))
+ goto out;
+

WARN_ON_ONCE() will drop a stack trace to the console - is that going to be useful?

If you want a message perhaps:

if (!nb) {
printk_once("something interesting about not having access to north bridge\n")
goto out;
}

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/