Re: [PATCH 1/2] pinctrl: select_state: don't call pinctrl_free_settingon error

[Linus Walleij]

On Fri, Mar 29, 2013 at 10:03 AM, Richard Genoud
<richard.genoud@xxxxxxxxx> wrote:

> As Stephen Warren pointed out, pinctrl_free_setting() was called instead
> of pinmux_disable_setting() on error.
> In this error code, we want to call pinmux_disable_setting() where
> pinmux_enable_setting() was called.
> And when pinconf_apply_setting() was called, we can't do much to undo
> the pin muxing (the closest thing I can think about for "unmuxing" a pin
> is muxing it as GPIO input).
>
> Signed-off-by: Richard Genoud <richard.genoud@xxxxxxxxx>
> ---
> This commit is on top of:
> [PATCH 3/3] pinctrl: pinctrl_select_state: set the old_state back on error

Patch applied with Stephen's Review tag.

Thanks,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/