Re: [patch v6 13/21] sched: using avg_idle to detect bursty wakeup

From: Alex Shi
Date: Wed Apr 03 2013 - 04:10:58 EST


On 04/03/2013 01:08 PM, Namhyung Kim wrote:
>> > - for_each_cpu(i, sched_group_cpus(group))
>> > - sgs->group_util += max_rq_util(i);
>> > + for_each_cpu(i, sched_group_cpus(group)) {
>> > + struct rq *rq = cpu_rq(i);
>> > +
>> > + if (burst && rq->nr_running > 1)
>> > + /* use nr_running as instant utilization */
>> > + sgs->group_util += rq->nr_running;
> I guess multiplying FULL_UTIL to rq->nr_running here will remove
> special-casing the burst in is_sd_full(). Also moving this logic to
> max_rq_util() looks better IMHO.
>
>

Thanks Namhyung! patch updated.