Re: [PATCH 3/5 v2] USB: enclose EHCI HCD drivers within an ifUSB_EHCI_HCD block

From: Alan Stern
Date: Tue Apr 02 2013 - 14:33:43 EST


On Tue, 2 Apr 2013, Florian Fainelli wrote:

> Thist patch removes the depends on USB_EHCI_HCD that the various USB
> EHCI HCD drivers use and encloses every driver within an if USB_EHCI_HCD
> / endif block. The EHCI HCD platform and Octeon drivers have been moved
> around to remain enclosed within this block.
>
> Signed-off-by: Florian Fainelli <florian@xxxxxxxxxxx>

Okay except for two things. First, you missed the
USB_EHCI_BIG_ENDIAN_DESC entry. Second, the Kconfig file has this
right in the middle of the section you changed:

config USB_FSL_MPH_DR_OF
tristate

It's probably a mistake to put this under the "if USB_EHCI_HCD"
umbrella. I guess it should be moved out of the way.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/