Re: [PATCH 09/23] perf: make cfi unwind support based on CONFIG_LIBUNWIND

[David Ahern]

On 4/2/13 3:32 AM, Paul Bolle wrote:
> On Mon, 2013-04-01 at 21:54 -0600, David Ahern wrote:
> > --- a/tools/perf/Pconfig
> > +++ b/tools/perf/Pconfig
> > @@ -1,3 +1,14 @@
> > +config ARCH
> > +    string
> > +    option env="ARCH"
>
> Why does this copy init/Kconfig?
>
> > +config X86
> > +    def_bool y if ARCH = "x86"
> > +    select HAVE_CFI_UNWIND_SUPPORT
> > +
>
> Doesn't this clash with the same Kconfig symbol in arch/x86/Kconfig?

traditionally, perf has not required a kernel config to build it. The 
above grabs some symbols for a standalone perf config. I guess that's a 
question to be answered - should the kernel's config files should be 
used for perf (or a tools target in general).

Also, perf can be built outside of the kernel tree. Tying the build to 
the kernel config files would have an affect on that option.

Something to look at for the next version.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/