Re: [PATCHv2, RFC 07/30] thp, mm: introducemapping_can_have_hugepages() predicate

[Kirill A. Shutemov]

Dave Hansen wrote:
> On 03/22/2013 03:12 AM, Kirill A. Shutemov wrote:
> > Dave Hansen wrote:
> >> On 03/14/2013 10:50 AM, Kirill A. Shutemov wrote:
> >>> +static inline bool mapping_can_have_hugepages(struct address_space *m)
> >>> +{
> >>> +	if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) {
> >>> +		gfp_t gfp_mask = mapping_gfp_mask(m);
> >>> +		return !!(gfp_mask & __GFP_COMP);
> >>> +	}
> >>> +
> >>> +	return false;
> >>> +}
> >>
> >> I did a quick search in all your patches and don't see __GFP_COMP
> >> getting _set_ anywhere.  Am I missing something?
> > 
> > __GFP_COMP is part of GFP_TRANSHUGE. We set it for ramfs in patch 20/30.
> 
> That's a bit non-obvious.  For a casual observer, it _seems_ like you
> should just be setting and checking GFP_TRANSHUGE directly.  It looks
> like you were having some problems with __GFP_MOVABLE and masked it out
> of GFP_TRANSHUGE and that has cascaded over to _this_ check.

Checking GFP_TRANSHUGE directly is not right way. File systems can clear
GFP bits or set additional for its own reason. We should not limit file
systems here.

So the only way robust way is to check __GFP_COMP. I'll add comment.

-- 
 Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/