Re: gpio-ucb1400

From: Mark Brown
Date: Tue Apr 02 2013 - 04:45:58 EST


On Tue, Apr 02, 2013 at 09:22:37AM +0200, Jean Delvare wrote:
> Le lundi 01 avril 2013 à 16:32 +0100, Mark Brown a écrit :

> > What the driver is doing is, unfortunately, the best practice for an
> > AC'97 connected device like this - we've got an uncomfortable mix of
> > an enumerable bus and platform data combined with a subsystem which has
> > never had enough love to work in a nice way with the kernel. The idea
> > is that any boards which have the device will call the _set_data()
> > function in their board-specific code.

> OK but where are these users? I can't see any in the upstream kernel.

They'll be out of tree I guess, it's fairly common (especially for the
hacky bits like this) for things to struggle to make it to mainline.

> > Sadly we're a little short on volunteers to clean up the AC'97
> > subsystem so this situation shows little sign of improving.

> Well Marek proposed a cleanup which looked good [1], several times
> apparently, but it was never applied.

That's not really doing much for the whole AC'97 problem although it
does help a bit with that particular driver providing the AC'97
controller driver it's used with has had support added for passing
platform data through. Don't see any reason not to apply it though,
you're probably just looking at a busy/missing maintainer problem there.

Attachment: signature.asc
Description: Digital signature