Re: [PATCH] memcg: don't do cleanup manually if mem_cgroup_css_online()fails

[Li Zefan]

On 2013/4/2 15:35, Li Zefan wrote:
> If memcg_init_kmem() returns -errno when a memcg is being created,
> mem_cgroup_css_online() will decrement memcg and its parent's refcnt,

> (but strangely there's no mem_cgroup_put() for mem_cgroup_get() called
> in memcg_propagate_kmem()).

The comment in memcg_propagate_kmem() suggests it knows mem_cgroup_css_free()
will be called in failure, while mem_cgroup_css_online() doesn't know.

> 
> But then cgroup core will call mem_cgroup_css_free() to do cleanup...
> 
> Signed-off-by: Li Zefan <lizefan@xxxxxxxxxx>
> ---
>  mm/memcontrol.c | 11 +----------
>  1 file changed, 1 insertion(+), 10 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/