Re: [PATCH] pwm: twl: Return proper error if twl6030_pwm_enable()fails

From: Peter Ujfalusi
Date: Tue Apr 02 2013 - 03:15:08 EST


On 03/31/2013 05:07 PM, Axel Lin wrote:
> Return proper error instead of 0 if twl6030_pwm_enable() fails.
>
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>

Acked-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx>

> ---
> drivers/pwm/pwm-twl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pwm/pwm-twl.c b/drivers/pwm/pwm-twl.c
> index ee7fa5d..2782001 100644
> --- a/drivers/pwm/pwm-twl.c
> +++ b/drivers/pwm/pwm-twl.c
> @@ -248,7 +248,7 @@ static int twl6030_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm)
> twl->twl6030_toggle3 = val;
> out:
> mutex_unlock(&twl->mutex);
> - return 0;
> + return ret;
> }
>
> static void twl6030_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm)
>


--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/