Re: [PATCH] cpufreq: cpufreq-cpu0: No need to check cpu number ininit()

[Shawn Guo]

On Sat, Mar 30, 2013 at 06:26:29PM +0530, Viresh Kumar wrote:
> It is not possible for init() to be called for any cpu other than cpu0. During
> bootup whatever cpu is used to boot system will be assigned as cpu0. And later
> on policy->cpu can only change if we hotunplug all cpus first and then hotplug
> them back in different order, which isn't possible (system requires atleast one
> cpu to be up always :)).
> 
> Though I can see one situation where policy->cpu can be different then zero.
> - Hot-unplug cpu 0.
> - rmmod cpufreq-cpu0 module
> - insmod it back
> - hotplug cpu 0 again.
> 
> Here, policy->cpu would be different. But the driver doesn't have any dependency
> on cpu0 as such. We don't mind which cpu of a system is policy->cpu and so this
> check is just not required.
> 
> Remove it.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

Acked-by: Shawn Guo <shawn.guo@xxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/