Re: [PATCH 1/5] power: ds2782_battery: Use dev_pm_ops

From: Anton Vorontsov
Date: Mon Apr 01 2013 - 02:04:56 EST


On Sun, Mar 10, 2013 at 02:34:05PM +0100, Lars-Peter Clausen wrote:
> Use dev_pm_ops instead of the deprecated legacy suspend/resume callbacks.
>
> Cc: Evgeny Romanov <romanov@xxxxxxxxxxxx>
> Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx>
> ---
[...]
> @@ -465,11 +466,10 @@ MODULE_DEVICE_TABLE(i2c, ds278x_id);
> static struct i2c_driver ds278x_battery_driver = {
> .driver = {
> .name = "ds2782-battery",
> + .pm = DS278X_BATERY_PM_OPS,

Typo: BATTERY.

CHECK drivers/power/ds2782_battery.c
drivers/power/ds2782_battery.c:464:27: error: undefined identifier 'DS278X_BATERY_PM_OPS'
CC drivers/power/ds2782_battery.o
drivers/power/ds2782_battery.c:464:9: error: âDS278X_BATERY_PM_OPSâ undeclared here (not in a function)
make[1]: *** [drivers/power/ds2782_battery.o] Error 1

I fixed it up and applied the patch...

Thanks,

Anton

> },
> .probe = ds278x_battery_probe,
> .remove = ds278x_battery_remove,
> - .suspend = ds278x_suspend,
> - .resume = ds278x_resume,
> .id_table = ds278x_id,
> };
> module_i2c_driver(ds278x_battery_driver);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/