RE: [PATCH] power: pass IRQF_ONESHOT to request_threaded_irq()

From: Kim, Milo
Date: Wed Mar 27 2013 - 21:19:55 EST


> -----Original Message-----
> From: Andrei Epure [mailto:epure.andrei@xxxxxxxxx]
> Sent: Thursday, March 28, 2013 9:43 AM
> To: cbou@xxxxxxx; dwmw2@xxxxxxxxxxxxx; Kim, Milo;
> broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> patches@xxxxxxxxxxxxxxxxxxxxxxxxxxx
> Cc: Andrei Epure
> Subject: [PATCH] power: pass IRQF_ONESHOT to request_threaded_irq()
>
> Patch found using coccinelle.
>
> Signed-off-by: Andrei Epure <epure.andrei@xxxxxxxxx>
> ---
> drivers/power/ab8500_btemp.c | 2 +-
> drivers/power/ab8500_charger.c | 2 +-
> drivers/power/ab8500_fg.c | 2 +-
> drivers/power/lp8788-charger.c | 2 +-
> drivers/power/max17042_battery.c | 3 ++-
> drivers/power/max8903_charger.c | 12 +++++++++---
> drivers/power/pm2301_charger.c | 2 +-
> drivers/power/smb347-charger.c | 3 ++-
> drivers/power/wm831x_power.c | 8 +++++---
> 9 files changed, 23 insertions(+), 13 deletions(-)

Could you share what will happen without this patch?
Do you mean the IRQF_ONESHOT flag with a primary IRQ handler?
If yes, no need to handle this for lp8788-charger driver because it is
a nested handler rather a default primary handler.
Handler function is replaced with irq_nested_primary_handler() on setting up
the IRQ.

Thanks.

Regards,
Milo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/