Re: [PATCH] bnx2x: fix assignment of signed expression to unsignedvariable

From: David Miller
Date: Sat Mar 23 2013 - 19:57:02 EST


From: Kumar Amit Mehta <gmate.amit@xxxxxxxxx>
Date: Sat, 23 Mar 2013 11:52:55 -0700

> fix for incorrect assignment of signed expression to unsigned variable.
>
> Signed-off-by: Kumar Amit Mehta <gmate.amit@xxxxxxxxx>

Returning positive error codes is just as broken as what is there
currently.

These routines should return 0 or 1, the return value isn't even used
in any way, it is just tested against zero.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/