Re: [PATCH 2/5] arm: mvebu: Select DMA_BOUNCE when LPAE isselected in Kconfig

From: Russell King - ARM Linux
Date: Fri Mar 22 2013 - 07:33:49 EST


On Thu, Mar 21, 2013 at 05:26:15PM +0100, Gregory CLEMENT wrote:
> From: Lior Amsalem <alior@xxxxxxxxxxx>
>
> For mvebu IOs are 32 bits and we have 40 bits memory due to LPAE so
> make sure we give 32 bits addresses to the IOs.
>
> Signed-off-by: Lior Amsalem <alior@xxxxxxxxxxx>
> Tested-by: Franklin <flin@xxxxxxxxxxx>
> Signed-off-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxxxxxxxxx>

Oh god no. Please move away from the addition on DMABOUNCE - that code
creaks, doesn't have highmem support, and is known to give problems on
various platforms.

Instead, please rely on using the DMA mask and such like, just like on
x86.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/