Re: [PATCH] hwrng: exynos - add CONFIG_PM_SLEEP to suspend/resumefunctions

From: David Rientjes
Date: Thu Mar 21 2013 - 15:17:16 EST


On Thu, 21 Mar 2013, Herbert Xu wrote:

> > This patch adds CONFIG_PM_SLEEP to suspend/resume functions to fix
> > the following build warning when CONFIG_PM_SLEEP is not selected.
> >
> > drivers/char/hw_random/exynos-rng.c:147:12: warning: 'exynos_rng_runtime_suspend' defined but not used [-Wunused-function]
> > drivers/char/hw_random/exynos-rng.c:157:12: warning: 'exynos_rng_runtime_resume' defined but not used [-Wunused-function]
> >
> > Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
>
> Patch applied. Thanks.

Nack, it causes build errors when CONFIG_PM_SLEEP is disabled:

drivers/char/hw_random/exynos-rng.c:167:8: error: 'exynos_rng_runtime_suspend' undeclared here (not in a function)
drivers/char/hw_random/exynos-rng.c:167:8: error: 'exynos_rng_runtime_resume' undeclared here (not in a function)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/