Re: [PATCH 3/4] writeback: replace custom worker pool implementationwith unbound workqueue

From: Tejun Heo
Date: Thu Mar 21 2013 - 14:37:23 EST


Hey, Christoph.

On Thu, Mar 21, 2013 at 09:08:19AM -0400, Christoph Hellwig wrote:
> > > Hmm... I guess, then, what we can do is adding a worker description
> > > which is printed out with task dump. ie. A work function can call
> > > work_set_desc(fmt, arg....). It won't be expensive and can be
> > > implemented relatively easily. Does that sound good enough?
> > Yeah, that sounds good! Thanks!
>
> How about automatically doing this based on the workqueue name?

We already have that information and just need to print it. The thing
is some users including writeback want further identifying information
inside the workqueue. The same workqueue would be serving all
writeback work items but it would be nice to be able to distinguish
which specific device was being serviced, so we need more information
than the associated workqueue.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/