Re: [PATCH 03/11] ARM: timer-sp: convert to use CLKSRC_OF init

From: Linus Walleij
Date: Thu Mar 21 2013 - 14:03:03 EST


On Wed, Mar 20, 2013 at 11:54 PM, Rob Herring <robherring2@xxxxxxxxx> wrote:

> From: Rob Herring <rob.herring@xxxxxxxxxxx>
>
> This adds CLKSRC_OF based init for sp804 timer. The clock initialization is
> refactored to support retrieving the clock(s) from the DT.
>
> Signed-off-by: Rob Herring <rob.herring@xxxxxxxxxxx>
(...)
> @@ -186,6 +201,57 @@ void __init sp804_clockevents_init(void __iomem *base, unsigned int irq,
> evt->irq = irq;
> evt->cpumask = cpu_possible_mask;
>
> + writel(0, clkevt_base + TIMER_CTRL);
> +

Wait, patch 1/11 depends on this being done first, right?

So patch 1/11 has to be moved after this one in the series
to avoid bisectability problems?

Apart from that:
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/