Re: [PATCH] sound: max98090: Remove executable bit

From: Mark Brown
Date: Thu Mar 21 2013 - 13:44:47 EST


On Thu, Mar 21, 2013 at 10:16:15AM -0700, Joe Perches wrote:
> On Thu, 2013-03-21 at 17:25 +0100, Mark Brown wrote:

> > I don't think you're quite understanding the issues with automation
> > here. Or indeed the desired end result.

> What issue is that?

That one needs a bit more taste and thought to work out what's
appropraite than can be guaranteed easily with a script, things like
working out drive level prefixes for example.

> Maybe this would work for you...

> $ cat .git/hooks/applypatch-msg
> #!/bin/sh

> . git-sh-setup

> perl -p -i -e 's/^(?:ASoC:\s*)?(.*)$/ASoC: $1/g if 1 .. 1' {$1+"$@"}

> test -x "$GIT_DIR/hooks/commit-msg" &&
> exec "$GIT_DIR/hooks/commit-msg" ${1+"$@"}
> :
> $

No, that's going to leave essentially every commit that needs fixing up
still needing manual fixup.

Attachment: signature.asc
Description: Digital signature