Re: [PATCH] DMA: OF: Check properties value before runningbe32_to_cpup() on it

From: Amit Kucheria
Date: Thu Mar 21 2013 - 07:26:17 EST

On Thu, Mar 21, 2013 at 4:08 PM, Vinod Koul <vinod.koul@xxxxxxxxx> wrote:
> On Thu, Mar 21, 2013 at 03:48:50PM +0530, Viresh Kumar wrote:
>> On 21 March 2013 15:16, Vinod Koul <vinod.koul@xxxxxxxxx> wrote:
>> > On Fri, Mar 15, 2013 at 02:18:20PM +0530, Viresh Kumar wrote:
>> >> In of_dma_controller_register() routine we are calling of_get_property() as an
>> >> parameter to be32_to_cpup(). In case the property doesn't exist we will get a
>> >> crash.
>> >>
>> >> This patch changes this code to check if we got a valid property first and then
>> >> runs be32_to_cpup() on it.
>> >>
>> >> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
>> >> ---
>> >>
>> >> My mails are broken, i have pushed this patch here:
>> > I noticed you used git send-email. Usually it will send patch properly
>> > independent of whatever MUA you use.
>> Probably not!! Its the famous (Infamous) Microsoft exchange server working in
>> background and it breaks mails without treating mails coming from git send-email
>> specially :)
> I have seen usually receiving patches is a problem, not sending. at least at my
> work place till now my sent patches have not been broken but what I receive has
> thus forcing me to use non exchange accounts for receiving email but somehow situation
> is better for receiving too :)
> --
> ~Vinod
>> > So I have the patch and its applied now :)
>> I have seen this kind of discrimination on breaking patches based on the size of
>> patch. If its very small (like this one), you may get a unbroken patch
>> but if the size
>> is a bit large then nobody can save you :)

I've seen the Exchange bug in both forms[1] - munging incoming
patches as well as outgoing ones. It almost feels like the Exchange
team's benevolent ploy to get companies to migrate away from Exchange
so they can end-of-life those servers and stop developing Exchange
further for the general betterment of humankind.[2]

[1] Since as far back as 8 years ago!
[2] That or they get bonuses based on how much they disrupt open
source communities. ;-)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at