Re: [PATCH RFC 1/5] kconfig: implement weak reverse-dependencies
From: Konstantin Khlebnikov
Date: Thu Mar 21 2013 - 07:06:23 EST
Richard Cochran wrote:
On Thu, Mar 21, 2013 at 12:22:57PM +0400, Konstantin Khlebnikov wrote:
This patch adds new kind of dependencies between kconfig symbols,
and new kconfig keyword 'apply' for them.
'apply' works mostly like 'select', but it allows to disable target symbol.
Thus target symbol will be either disabled or reachable from current symbol.
This method allows to implement optional dependencies without introducing new
kconfig symbol for each pair of connected kconfig options.
I don't really understand what the point of this new keyword is, but I
wonder why you chose PTP Hardware Clocks as your Guinea pig.
As discussed on the netdev list , the consensus was that if a
MAC driver has a PHC, then it should always be compiled in.
I don't like situations when really optional code becomes mandatory.
As I see this technology requires special dedicated server in the local
network, thus it's unusable in most situations. But it starts working
without any actions from the user (please fix me if I'm wrong).
Thus this code enables some rarely used parts of hardware.
After seeing several weird bugs in ethernet devices I prefer to
keep unused/unwanted features off.
And BTW, please CC netdev for PHC patches.
Of course, if basic logic of this RFC patchset will be approved I'll resend
PTP part to netdev. I don't want to bother netdev guys because PTP and e1000e
are used here just as Guinea pigs.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/