Re: request line field in the generic slave config structure

From: Vinod Koul
Date: Thu Mar 21 2013 - 06:36:26 EST


On Mon, Mar 18, 2013 at 01:30:29PM +0000, Arnd Bergmann wrote:
> On Monday 18 March 2013, Shevchenko, Andriy wrote:
> > Hello!
> >
> > It seems the one (as I think good) question was left unanswered:
> > http://www.spinics.net/lists/arm-kernel/msg186120.html
> >
> > What is your opinions, comments?
>
> I'm not sure I understand what the question was. Is this about
> whether we should remove the "slave_id" field in the slave
> configuration?
Ditto :)

The slave_id memeber in dma_slave_config should be used for this

>
> Those sort of duplicate the request line information that comes
> from the platform in a data structure that should be filled by
> the device driver without platform specific knowledge.
>
> I believe that is currently used by shmobile, and we won't be able
> to kill that before that platform has been converted to use
> dma_request_slave_channel.
>
> Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/