Re: [PATCH v3 5/6] ARM: dts: omap: update usb_otg_hs data

[kishon]

Hi,

On Thursday 21 March 2013 02:29 AM, Stephen Warren wrote:
> On 03/20/2013 03:12 AM, Kishon Vijay Abraham I wrote:
> > Updated the usb_otg_hs dt data to include the *phy* and *phy-names*
> > binding in order for the driver to use the new generic PHY framework.
> > Also updated the Documentation to include the binding information.
>
> > diff --git a/Documentation/devicetree/bindings/usb/omap-usb.txt b/Documentation/devicetree/bindings/usb/omap-usb.txt
> > index abce256..3d6f9f6 100644
> > --- a/Documentation/devicetree/bindings/usb/omap-usb.txt
> > +++ b/Documentation/devicetree/bindings/usb/omap-usb.txt
> > @@ -19,6 +19,9 @@ OMAP MUSB GLUE
> >    - power : Should be "50". This signifies the controller can supply upto
> >      100mA when operating in host mode.
> >    - usb-phy : the phandle for the PHY device
> > + - phy : the phandle for the PHY device (used by generic PHY framework)
> > + - phy-names : the names of the PHY corresponding to the PHYs present in the
> > +   *phy* phandle.
>
> If the intent is for those properties to be generic and used by any DT
> binding that refers to a PHY node, I think you'd want to define those
> properties in e.g. Documentation/devicetree/bindings/phy/phy.txt, just
> like common clock/GPIO/... properties are defined in standalone common
> files.

Ok. Will add it.
> I think you want to require that DT nodes that represent PHYs have a
> #phy-cells property, and that the format of the phy property be
> <&phy_phandle phy_specifier*>, where #phy-cells in the referenced node
> defines how many cells are part of phy_specifier*, just like (almost)
> any other DT property that references another node by phandle. That way,
> if a single DT node represents a HW block that implements e.g. 3 PHYs,
> it can use #phy-cells = <1>, and the referencing phy property can
> include a cell that indicates which of those 3 PHYs is being referenced.

Currently, if a single phandle have reference to multiple PHYs, we can 
get PHY by passing index or by name as give in phy-names.
I'm not sure if we have <&phy_phandle phy_specifier*>, what could that 
phy_specifier be? Maybe phy_type?

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/