Re: [PATCH} mm: Merging memory blocks resets mempolicy

From: Andrew Morton
Date: Wed Mar 20 2013 - 18:02:55 EST


On Mon, 18 Mar 2013 06:13:42 +0000 "Hampson, Steven T" <steven.t.hampson@xxxxxxxxx> wrote:

> Using mbind to change the mempolicy to MPOL_BIND on several adjacent
> mmapped blocks
> may result in a reset of the mempolicy to MPOL_DEFAULT in vma_adjust.
>
> ...
>
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -820,7 +820,7 @@ again: remove_next = 1 + (end > next->vm_end);
> if (next->anon_vma)
> anon_vma_merge(vma, next);
> mm->map_count--;
> - mpol_put(vma_policy(next));
> + vma_set_policy(vma, vma_policy(next));
> kmem_cache_free(vm_area_cachep, next);
> /*
> * In mprotect's case 6 (see comments on vma_merge),

Is this missing an mpol_put(vma_policy(vma))?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/