Re: [PATCH] pciehp: Add pciehp_surprise module option

From: Takashi Iwai
Date: Wed Mar 20 2013 - 15:23:45 EST

At Wed, 20 Mar 2013 19:12:50 +0000,
Matthew Garrett wrote:
> On Wed, Mar 20, 2013 at 08:11:15PM +0100, Takashi Iwai wrote:
> > At Wed, 20 Mar 2013 17:52:34 +0000,
> > Matthew Garrett wrote:
> > > Well that just sounds like a bug. What's the downside to just ignoring
> > > that capability bit?
> >
> > I'm afraid that it's too radical to enable always.
> Why?

Because I'm conservative :)
Well, dunno. It's just my feeling without deep thought.

> > Or, what about to check this bit only for disable path?
> What happens if you unplug the device on one of the affected machines?

It continues working. I mean, the PCI device is still there after
unplug, but the Realtek driver unmounts it smoothly. Re-plugging also
works, too. So, the handling via pciehp is needed only for the very
first time to register the PCI device.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at