Re: [PATCHv3 08/10] clocksource: time-armada-370-xp: Fix sparse warning

From: Gregory CLEMENT
Date: Wed Mar 20 2013 - 13:07:09 EST


On 03/13/2013 07:17 PM, Stephen Boyd wrote:
> drivers/clocksource/time-armada-370-xp.c:217:13: warning: symbol
> 'armada_370_xp_timer_init' was not declared. Should it be static?
>
> Also remove the __init marking in the prototype as it's
> unnecessary and drop the init.h file.
>
> Cc: Gregory CLEMENT <gregory.clement@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
> ---
> drivers/clocksource/time-armada-370-xp.c | 3 ++-
> include/linux/time-armada-370-xp.h | 4 +---
> 2 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clocksource/time-armada-370-xp.c b/drivers/clocksource/time-armada-370-xp.c
> index 47a6730..efe4aef 100644
> --- a/drivers/clocksource/time-armada-370-xp.c
> +++ b/drivers/clocksource/time-armada-370-xp.c
> @@ -27,10 +27,11 @@
> #include <linux/of_address.h>
> #include <linux/irq.h>
> #include <linux/module.h>
> +#include <linux/percpu.h>
> +#include <linux/time-armada-370-xp.h>
>
> #include <asm/sched_clock.h>
> #include <asm/localtimer.h>
> -#include <linux/percpu.h>
> /*
> * Timer block registers.
> */
> diff --git a/include/linux/time-armada-370-xp.h b/include/linux/time-armada-370-xp.h
> index dfdfdc0..6fb0856 100644
> --- a/include/linux/time-armada-370-xp.h
> +++ b/include/linux/time-armada-370-xp.h
> @@ -11,8 +11,6 @@
> #ifndef __TIME_ARMADA_370_XPPRCMU_H
> #define __TIME_ARMADA_370_XPPRCMU_H
>
> -#include <linux/init.h>
> -
> -void __init armada_370_xp_timer_init(void);
> +void armada_370_xp_timer_init(void);
>
> #endif
>
Acked-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxxxxxxxxx>

--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/