Re: [BUG] staging: android: ashmem: Deadlock during ashmem_mmap andashmem_read

From: Al Viro
Date: Wed Mar 20 2013 - 12:09:12 EST


On Wed, Mar 20, 2013 at 09:08:03PM +0530, Shankar Brahadeeswaran wrote:
> Hi Greg, Dan,
>
> Few days back I posted a patch to fix a dead lock issue in the ashmem
> driver that got merged in staging-next branch
> https://lkml.org/lkml/2013/2/20/429
>
> I'm seeing that there exists another path in the ashmem driver that
> could lead to the similar issue. But this time I'm unable to think of
> a way to fix the problem.
>
> - The objects involved in the deadlock are same, mmap->sem and ashmem_mutex

Umm... why does it need to hold that mutex past having checked that
asma->file is non-NULL, anyway?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/