Re: [PATCH 08/10] workqueue: break init_and_link_pwq() into twofunctions and introduce alloc_unbound_pwq()

From: Tejun Heo
Date: Wed Mar 20 2013 - 12:04:27 EST


On Wed, Mar 20, 2013 at 11:52:03PM +0800, Lai Jiangshan wrote:
> > +static struct pool_workqueue *alloc_unbound_pwq(struct workqueue_struct *wq,
> > + const struct workqueue_attrs *attrs)
> > +{
> > + struct worker_pool *pool;
> > + struct pool_workqueue *pwq;
> > +
> > + pool = get_unbound_pool(attrs);
> > + if (!pool)
> > + return NULL;
> > +
> > + pwq = kmem_cache_zalloc(pwq_cache, GFP_KERNEL);
>
> this allocation is not numa-awared, you may use pool->node here.

Nice catch. Will do.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/