Re: [PATCH 2/2] regulator: palmas: add input supply names

From: Laxman Dewangan
Date: Wed Mar 20 2013 - 09:34:58 EST


On Wednesday 20 March 2013 06:55 PM, Mark Brown wrote:
* PGP Signed by an unknown key

On Wed, Mar 20, 2013 at 06:24:54PM +0530, Laxman Dewangan wrote:

The regulator core register the regulator even if there is NULL
init_data and in this case, it tries to findout the input-supply
(provided through desc->supply_name) and it fails to find out the
supply handle and so regulator register fails cause all regulator
registration to fail.
So providing the dec->supply_name only in case of valid init_data.
This works fine if you have a device per regulator instead of a device
for all the regulators on the chip... I would be inclined to address
this by providing a "floating" supply and connecting everythinng to
that.
I am fine with adding floating supply similar to below and connect all non-connected supply pins to this.

floating: regulator@1 {
compatible = "regulator-fixed";
reg = <1>;
regulator-name = "floating";
};

If this is fine then I will respin the patch to remove condition.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/