Re: linux-next: build failure after merge of the tty tree

From: Bill Pemberton
Date: Wed Mar 20 2013 - 08:51:42 EST

Jiri Slaby writes:
> > drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb':
> > drivers/usb/serial/quatech2.c:661:18: error: 'struct
> > qt2_port_private' has no member named 'is_open'
> > drivers/usb/serial/quatech2.c:705:15: error: 'struct
> > qt2_port_private' has no member named 'is_open'
> >
> > Caused by commit e4408ce3c23f ("TTY: quatech2, remove unneeded
> > is_open"). grep is your friend (or searching while editting the
> > file).
> I think this is caused by another commit. Bill added a check for
> is_open meanwhile I removed that member completely. Bill, could you
> fix that up, please?

Is it legal to call tty_flip_buffer_push() without an open tty? If
so, I can get rid of the is_open logic completely. Otherwise, I need
to either keep is_open or otherwise check for a valid tty before
calling tty_flip_buffer_push().

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at