Re: [PATCH V5 4/5] virtio-scsi: introduce multiqueue support
From: Wanlong Gao
Date: Wed Mar 20 2013 - 03:23:33 EST
On 03/20/2013 09:46 AM, Venkatesh Srinivas wrote:
> This looks pretty good!
> I rather like the (lack of) locking in I/O completion (around the req
> count vs. target/queue binding). It is unfortunate that you need to hold the per-target lock in virtscsi_pick_vq() though; have any idea
> how much that lock hurts?
> Just two minor comments:
> (in struct virtio_scsi_target_data):
> + /* This spinlock never help at the same time as vq_lock. */
> ^^^^ held?
> (in struct virtio_scsi):
> + /* Does the affinity hint is set for virtqueues? */
> Could you rephrase that, please?
Thank you, fixed in V6, please review.
> Tested on qemu and w/ Google Compute Engine's virtio-scsi device.
> Reviewed-and-tested-by: Venkatesh Srinivas <venkateshs@xxxxxxxxxx>
Do you mind review and test the V6? Thank you.
> -- vs;
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/