Re: linux-next: build failure after merge of the final tree (cgrouptree related)

[Stephen Rothwell]

Hi all,

On Wed, 13 Mar 2013 14:33:15 +0800 Li Zefan <lizefan@xxxxxxxxxx> wrote:
>
> On 2013/3/13 13:12, Stephen Rothwell wrote:
> > 
> > After merging the final tree, today's linux-next build (powerpc
> > allnoconfig) failed like this:
> > 
> > In file included from include/linux/memcontrol.h:22:0,
> >                  from include/linux/swap.h:8,
> >                  from include/linux/suspend.h:4,
> >                  from arch/powerpc/kernel/asm-offsets.c:24:
> > include/linux/cgroup.h:748:13: warning: 'struct cgroupstats' declared inside parameter list [enabled by default]
> > include/linux/cgroup.h:748:13: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
> > cc1: all warnings being treated as errors
> > 
> > and many more similar.
> > 
> > Caused by commit c2c9ad164fa3 ("cgroup: remove unneeded includes from
> > cgroup.h").
> > 
> 
> Tejun has dropped this patch.

It has returned today.  Please be more careful.

In file included from include/linux/memcontrol.h:22:0,
                 from include/linux/swap.h:8,
                 from include/linux/suspend.h:4,
                 from arch/powerpc/kernel/asm-offsets.c:24:
include/linux/cgroup.h:742:13: warning: 'struct cgroupstats' declared inside parameter list [enabled by default]
include/linux/cgroup.h:742:13: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]

I have reverted commit c2c9ad164fa3 ("cgroup: remove unneeded includes
from cgroup.h") for today.
-- 
Cheers,
Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx

Attachment: pgp00000.pgp
Description: PGP signature