Re: [PATCH v7 1/9] mfd: Add commands abstraction layer for SI476X MFD

From: Andrey Smirnov
Date: Tue Mar 19 2013 - 21:10:37 EST

On Mon, Mar 18, 2013 at 1:11 PM, Mauro Carvalho Chehab
<mchehab@xxxxxxxxxx> wrote:
> Em Tue, 26 Feb 2013 22:06:45 -0800
> Andrey Smirnov <andrew.smirnov@xxxxxxxxx> escreveu:
>> This patch adds all the functions used for exchanging commands with
>> the chip.
> Please run over those patches. There are a number of compliants
> on those patches:

OK, will do shortly and send updated patch-set.

> WARNING: line over 80 characters
> #328: FILE: drivers/mfd/si476x-cmd.c:298:
> + err = si476x_core_i2c_xfer(core, SI476X_I2C_SEND, (char *) data, argn + 1);
> WARNING: line over 80 characters
> #378: FILE: drivers/mfd/si476x-cmd.c:348:
> + dev_err(&core->client->dev, "[CMD 0x%02x] Chip set error flag\n", command);

I do have a question about this particular warning though. Weird
indentation that I had to use in order to calm about
that issue has been a topic of discussion and complaints once
already(see To my understanding
the consensus was as far as it improves readability > 80 character
lines are OK. What would you like me do with those extra long lines
ignore all/fix all/use discretion and fix some?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at